Re: squid-3.HEAD IPAddress leak

> On Thu, Feb 07, 2008, Robert Collins wrote:
>
>> > Still, this is one of those "death of a thousand cuts" method of
>> > killing performance..
>>
>> Right, I haven't seen the commit; care to mail the diff?
>
> Which? I just looked at the places where Amos is calling GetAddrInfo()
> and FreeAddrInfo(); more then one are:
>
> * GetAddrInfo(temp, );
> * F->{something} = temp;
> * FreeAddrInfo(temp);

Where?!

 I hate addrinfo enough that I only added addrinfo where it needed:

 GetAddrInfo(temp)
 syscall_needing_neutral_sockaddr_size_family(temp)
 FreeAddrInfo(temp)

OR:

 GetAddrInfo(temp)
 syscall_altering_addrinfo(temp)
 F->something = temp;
 FreeAddrInfo(temp)

Amos
Received on Thu Feb 07 2008 - 14:30:34 MST