Re: squid-3.HEAD IPAddress leak

Have you tried running valgrind?

Also, wait. What exactly are you using addr_info for? Can you explain it
to me?

There's a netural sock addr size type - its called sockaddr_storage.
addr_info is for return results from hostname<->ip queries..

Adrian

On Fri, Feb 08, 2008, Amos Jeffries wrote:
> > On Thu, Feb 07, 2008, Robert Collins wrote:
> >
> >> > Still, this is one of those "death of a thousand cuts" method of
> >> > killing performance..
> >>
> >> Right, I haven't seen the commit; care to mail the diff?
> >
> > Which? I just looked at the places where Amos is calling GetAddrInfo()
> > and FreeAddrInfo(); more then one are:
> >
> > * GetAddrInfo(temp, );
> > * F->{something} = temp;
> > * FreeAddrInfo(temp);
>
> Where?!
>
> I hate addrinfo enough that I only added addrinfo where it needed:
>
> GetAddrInfo(temp)
> syscall_needing_neutral_sockaddr_size_family(temp)
> FreeAddrInfo(temp)
>
> OR:
>
> GetAddrInfo(temp)
> syscall_altering_addrinfo(temp)
> F->something = temp;
> FreeAddrInfo(temp)
>
>
> Amos
>

-- 
- Xenion - http://www.xenion.com.au/ - VPS Hosting - Commercial Squid Support -
- $25/pm entry-level VPSes w/ capped bandwidth charges available in WA -