Re: Bug #1893; why's it incomplete?

From: Henrik Nordstrom <henrik_at_henriknordstrom.net>
Date: Fri, 13 Jun 2008 03:02:41 +0200

On ons, 2008-06-11 at 20:24 +0800, Adrian Chadd wrote:

> Ok. I'll commit a reversal of the patch later on.

Done by applying the 2.7 reversal patch..

Note: THere is one more known incomplete change in 2.HEAD.. the hack to
use the client provided IP if DNS lookup fails (transparent interception
only). Problem is that it does not play well with dst type acls..

Imho it should be redone to always use the client provided ip in such
setups and encode it into the cache key, at the cost of a bit of hit
ratio on sites with multiple IPs.

Regards
Henrik

Received on Fri Jun 13 2008 - 01:02:47 MDT

This archive was generated by hypermail 2.2.0 : Fri Jun 13 2008 - 12:00:05 MDT