Re: R: /bzr/squid3/trunk/ r9713: MFC: Back out unintended md5 -> squid_md5 substituions from the md5.h -> squid_md5.h name change

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Tue, 02 Jun 2009 22:21:57 +1200

Guido Serassio wrote:
> Hi Amos,
>
> This one:
>
> http://www.squid-cache.org/Versions/v2/HEAD/changesets/11865.patch
>
> It seems that only the changes to radius-util.c was forgotten, but
> also config.test was missing from the squid_radius_auth directory. So
> probably nobody have compiled it since very much time, without
> discovering that the build of squid_radius_auth was always failing.
>

Ah okay. Noted. Carefully though, the MD5 changes are still very
different. The proper portable merger is not yet done.

AFAICT the config.test are only used on windows builds so it is indeed
likely not to have been built in a long time.

> Regards
>
> Guido Serassio
>
> Acme Consulting S.r.l. - Microsoft Certified Partner Via Lucia
> Savarino, 1 10098 - Rivoli (TO) - ITALY Tel. :
> +39.011.9530135 Fax. : +39.011.9781115 Email:
> info@acmeconsulting.it WWW: http://www.acmeconsulting.it/
>
>
>> -----Messaggio originale----- Da: Amos Jeffries
>> [mailto:squid3_at_treenet.co.nz] Inviato: luned́ 1 giugno 2009 14.43
>> A: Squid Developers Cc: squid-cvs_at_squid-cache.org Oggetto: Re:
>> /bzr/squid3/trunk/ r9713: MFC: Back out unintended md5 -> squid_md5
>> substituions from the md5.h -> squid_md5.h name change
>>
>> Guido Serassio wrote:
>>> ------------------------------------------------------------
>>> revno: 9713 committer: Guido Serassio <serassio_at_squid-cache.org>
>>> branch nick: HEAD-3 timestamp: Mon 2009-06-01 14:01:23 +0200
>>> message: MFC: Back out unintended md5 -> squid_md5 substituions
>>> from the md5.h
>> -> squid_md5.h name change
>>> somehow the global search/replace used when renaming
>>> include/md5.h
>> picked up a
>>> lot more than intended.
>>>
>>> This is a missing forward port from Squid 2 of an old Henrik's
>>> commit
>> Which one?
>>
>> I'm working on forward-ports and migrating include/* stuff into the
>> libcompat (with helper .cc'ing side effect) at present.
>>
>>> modified: helpers/basic_auth/squid_radius_auth/radius-util.c

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE6 or 3.0.STABLE15
   Current Beta Squid 3.1.0.8 or 3.0.STABLE16-RC1
Received on Tue Jun 02 2009 - 10:22:09 MDT

This archive was generated by hypermail 2.2.0 : Mon Jun 29 2009 - 12:00:05 MDT