Re: [PATCH] Bug 2680: ** helper errors after -k rotate

Henrik Nordstrom wrote:
> tor 2009-07-16 klockan 23:15 +1200 skrev Amos Jeffries:
>
>> Right, following up on that I had a hunch and discovered that n_active
>> is already performing this duty. The bug is therefore in my earlier fix
>> using n_running as a base instead of n_active.
>>
>> How does this new attached patch look to you two?
>
> Looks fine to me, assuming rotate still starts a new set of helpers
> (wasn't clear to me).

Yes, no longer touching mainRotate() at all with these.

> Will fix the "too many helpers have crashed, need
> to start new ones" case, and leave the rotate & reconfigure case alone.
>
> With this we can also start new helpers more or less immediately (at
> some seconds delay just in case) when seeing them crash...

Ah, good point. :)

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE6 or 3.0.STABLE16
   Current Beta Squid 3.1.0.9