Re: /bzr/squid3/trunk/ r9845: Correct header limit checks. 64KB max is REQUIRED.

From: Alex Rousskov <rousskov_at_measurement-factory.com>
Date: Fri, 24 Jul 2009 14:24:30 -0600

> - if (hdr_len > Config.maxReplyHeaderSize || (hdr_len <= 0 && (size_t)buf->contentSize() > Config.maxReplyHeaderSize)) {
> + if (hdr_len >= Config.maxReplyHeaderSize || (hdr_len <= 0 && (size_t)buf->contentSize() > Config.maxReplyHeaderSize)) {

Does the comparison need to be ">="? On the surface, it seems like this
change contradicts expected maxReplyHeaderSize semantics and
documentation because the maximum header size should still be allowed.

Thank you,

Alex.
Received on Fri Jul 24 2009 - 20:25:22 MDT

This archive was generated by hypermail 2.2.0 : Sat Jul 25 2009 - 12:00:08 MDT