Re: /bzr/squid3/trunk/ r9845: Correct header limit checks. 64KB max is REQUIRED.

From: Henrik Nordstrom <henrik_at_henriknordstrom.net>
Date: Fri, 24 Jul 2009 22:31:02 +0200

fre 2009-07-24 klockan 14:24 -0600 skrev Alex Rousskov:
> > - if (hdr_len > Config.maxReplyHeaderSize || (hdr_len <= 0 && (size_t)buf->contentSize() > Config.maxReplyHeaderSize)) {
> > + if (hdr_len >= Config.maxReplyHeaderSize || (hdr_len <= 0 && (size_t)buf->contentSize() > Config.maxReplyHeaderSize)) {
>
> Does the comparison need to be ">="? On the surface, it seems like this
> change contradicts expected maxReplyHeaderSize semantics and
> documentation because the maximum header size should still be allowed.

It's because we do not want to go above 64KB-1 at this time.

Not sure anyone is going to care or even notice that 1 byte difference.

Regards
Henrik
Received on Fri Jul 24 2009 - 20:31:07 MDT

This archive was generated by hypermail 2.2.0 : Sat Jul 25 2009 - 12:00:08 MDT