Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

mån 2009-09-07 klockan 00:16 +1200 skrev Amos Jeffries:

> > ERROR: files left after uninstall:
> > ./etc/mime.conf
> > ./etc/squid.conf
> > make[1]: *** [distuninstallcheck] Error 1
> > make[1]: Leaving directory `<http://build.squid-cache.org/job/3.1-amd64-CentOS-5.3/ws/btlayer-00-default/squid-3.1.0.13-BZR/_build'>
>
> Is there a <bleep>ing random generator deciding the order of these
> automake targets?

Yes.

With no dependencies to guide it make reorders as it sees fit for the
day, especially if running parallel jobs.

squid.conf.default is listed as sysconf_DATA, which means it gets
automatically installed and uninstalled as such.

We also install that manually to $(DEFAULT_CONFIG_FILE).default in
install-data-local (slightly misplaced, shold be a local variant ofthe
sysconf_DATA targets, not general data)

The best is probably to make these be manually installed only by the
-local rules, marking them as noinst_sysconf_DATA in Makefile.am and
making sure the -local rules properly install/uninstall them. Just
remember to add a comment on why these are tagged as noinst_..

I guess it would also work adding a dependency that
uninstall-sysconfDATA depends on uninstall-data-local, if automake
accepts such dependency to be added, but we still have the issue of
automake installing them in sysconf on the Makefile.am specified name,
not caring about our DEFAULT_... variables. And looking closely I see
what we don't even have a rule to install $(DEFAULT_MIME_TABLE). It's
only installed by sysconf_DATA automatic rule as $(sysconfdir)/mime.conf

Regards
Henrik
Received on Sun Sep 06 2009 - 20:52:36 MDT