Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

From: Henrik Nordstrom <henrik_at_henriknordstrom.net>
Date: Mon, 07 Sep 2009 08:42:55 +0200

mån 2009-09-07 klockan 12:18 +1200 skrev Amos Jeffries:

> Tricky. That would place the hash at the wrong end of the file (last) where
> its most likely to be overlooked. Particularly on the longer config files.

Doesn't matter if it's overlooked.

> There are also some distros (notably Gentoo and clones) which override our
> upgrades and move squid.conf.documented into place post-install as their
> main squid.conf.

Distros using package managers is not a problem.

> Would embeding the hash(es) into Makefile or an install.state data file
> work instead?

No thanks. make all/install should not modify Makefile, and I do not
want yet another installed file.

But here is another idea. Have uninstall compare with the source
directory and not the target. Would probably be best. Will screw up if
someone tries "make clean" before "make uninstall" but that's their
problem. And if that's a problem then we can keep these built files
until "make distclean".

> Um, we might also have problems with distro like FreeBSD where md5sum is a
> non-standard script install. The srcformat scripts struggle with that
> already.

The format proposed used is output-agnostic, as long as the hasher
outputs something with a hash and no timestamps or other variable data
it will work.

but it's a bit messy as we also need to detect the proper binary for
making hashes.. md5 / md5sum.

Regards
Henrik
Received on Mon Sep 07 2009 - 06:43:03 MDT

This archive was generated by hypermail 2.2.0 : Mon Sep 07 2009 - 12:00:04 MDT