Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

Henrik Nordstrom wrote:
> mån 2009-09-07 klockan 12:18 +1200 skrev Amos Jeffries:
>
>> Tricky. That would place the hash at the wrong end of the file (last) where
>> its most likely to be overlooked. Particularly on the longer config files.
>
> Doesn't matter if it's overlooked.

?huh? if its overlooked it stays after an edit and the removal will
find it and delete the changed file when it should not have.

>
>> There are also some distros (notably Gentoo and clones) which override our
>> upgrades and move squid.conf.documented into place post-install as their
>> main squid.conf.
>
> Distros using package managers is not a problem.
>
>> Would embeding the hash(es) into Makefile or an install.state data file
>> work instead?
>
> No thanks. make all/install should not modify Makefile, and I do not
> want yet another installed file.
>
> But here is another idea. Have uninstall compare with the source
> directory and not the target. Would probably be best. Will screw up if
> someone tries "make clean" before "make uninstall" but that's their
> problem. And if that's a problem then we can keep these built files
> until "make distclean".

Thats more doable IMO.

>
>> Um, we might also have problems with distro like FreeBSD where md5sum is a
>> non-standard script install. The srcformat scripts struggle with that
>> already.
>
> The format proposed used is output-agnostic, as long as the hasher
> outputs something with a hash and no timestamps or other variable data
> it will work.
>
> but it's a bit messy as we also need to detect the proper binary for
> making hashes.. md5 / md5sum.

You misunderstood me.
On FreeBSD from what I've seen of squid-cache the md5sum 'binary' is:
   "/path/to/python<version> /path/to/md5sum.py"

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE6 or 3.0.STABLE18
   Current Beta Squid 3.1.0.13