Re: /bzr/squid3/trunk/ r10345: Remove remainder of EXTERNNEW hackup.

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Sat, 20 Mar 2010 23:04:29 +1300

Henrik Nordström wrote:
> lör 2010-03-20 klockan 03:50 +1300 skrev Amos Jeffries:
>
>> === modified file 'test-suite/test_tools.cc'
>> --- a/test-suite/test_tools.cc 2009-08-28 01:44:26 +0000
>> +++ b/test-suite/test_tools.cc 2010-03-19 14:50:48 +0000
>> @@ -5,7 +5,6 @@
>> // XXX: This file is made of large pieces of src/debug.cc and src/tools.cc
>> // with only a few minor modifications. TODO: redesign or delete.
>>
>> -#define _SQUID_EXTERNNEW_
>> #include "squid.h"
>>
>> /* AYJ: the debug stuff here should really be in a stub_debug.cc file for tests to link */
>
>
> Doesn'ẗ this crash the test suite linkage in the same manner as ufsdump
> was crashed?
>
> Or have the test linkage been fixed to include SquidNew.cc?
>

The test that was failing for the last day or so was doing so because it
linked SquidNew.o + test_tools.o.

It seems to pass all the testbed tests, so I assume the other ones that
need to link SquidNew.o as well.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE8 or 3.0.STABLE25
   Current Beta Squid 3.1.0.18
Received on Sat Mar 20 2010 - 10:04:39 MDT

This archive was generated by hypermail 2.2.0 : Sat Mar 20 2010 - 12:00:08 MDT