Re: Strange code in src/client_side_reply.cc

From: Kinkie <gkinkie_at_gmail.com>
Date: Tue, 13 Jul 2010 16:28:38 +0200

On Fri, Jul 9, 2010 at 11:02 PM, Alex Rousskov
<rousskov_at_measurement-factory.com> wrote:
> On 07/09/2010 06:08 AM, Kinkie wrote:
>
>> in client_side_reply.cc:clientHttpRequestStatus at about line 1050,
>> there's two conditionals:
>>
>> #if SIZEOF_INT64_T == 4
>> //..
>> #endif
>>
>> Both are pretty strange: sizeof(int64_t) cannot be 4, it's guarranteed to be 8.
>> I'm removing this code in autoconf-refactor, but I'd like to
>> understand if it's meant to be there..
>
>
> Apparently, there are some environments where 64-bit integers are only
> 4-bytes long:
> http://stackoverflow.com/questions/2661162/doing-64-bit-manipulation-using-32-bit-data-in-fixed-point-arithmetic-using-c
>
> However, I doubt we should spend time supporting such environments.

I agree.

> If the code is not related to your autoconf project, leave it alone or
> investigate/fix/remove separately.

Ok.
Thanks for the hint. I'd never have guessed it.

-- 
    /kinkie
Received on Tue Jul 13 2010 - 14:28:45 MDT

This archive was generated by hypermail 2.2.0 : Tue Jul 13 2010 - 12:00:16 MDT