Re: [PATCH] Add build info tag to squid -v output

On Tue, 7 Sep 2010 16:38:51 +0200, Kinkie <gkinkie_at_gmail.com> wrote:
> Hi all,
> here's the second release of the build-info patch.
> Changes:
> - address Amos' comments about configure test
> - implement Alex's "+changes" suggestion
> - fix the "extra empty line if no version" issue
>
> While testing it, I've discovered that test-builds.sh doesn't really
> handle arguments with embedded spaces well.
> I've reworked it to handle them better.
>
> I've build-and run- tested it.
> Please review.

Calling the variable DISTCHECK_CONFIGURE_FLAGS makes no sense when
"distcheck" is itself a variable selectable by the layer. CONFIGURE_FLAGS
would be sufficient.

Other than that. Okay. +1

Amos
Received on Wed Sep 08 2010 - 00:39:56 MDT