Re: [stringng patch] removes terminate() method from SBuf

From: Alex Rousskov <rousskov_at_measurement-factory.com>
Date: Fri, 17 Sep 2010 11:33:04 -0600

On 09/17/2010 01:19 AM, Amos Jeffries wrote:
> see IRC discussions 2010-09-17 for the reasons.
>
> Boils down to it not actually being needed and causing semantic problems
> when provided by SBuf().

I would not remove terminate() completely because it does provide needed
functionality. I would just make it private, document non-persistency
caveat, and call it from c_str() and other applicable methods. If it is
only used once, this becomes less important, of course, but I would
still keep the code isolated.

Cheers,

Alex.
Received on Fri Sep 17 2010 - 17:33:29 MDT

This archive was generated by hypermail 2.2.0 : Sat Sep 18 2010 - 12:00:06 MDT