Re: [PATCH] Bug 3150: do not start useless unlinkd.

On 08/10/11 12:53, Dmitry Kurochkin wrote:
> On Fri, 07 Oct 2011 15:54:34 -0600, Alex Rousskov<rousskov_at_measurement-factory.com> wrote:
>> On 10/07/2011 03:20 PM, Dmitry Kurochkin wrote:
>>> +bool
>>> +CossSwapDir::unlinkdUseful() const
>>> +{
>>> + // UFS storage does not have files to erase/unlink
>>> + return false;
>>> +}
>>> +
>>
>> This is about COSS, not UFS.
>
> oops
>
>> And since you would be changing this, I
>> would also change the message to something more precise like
>>
>> // no entry-specific files to remove/unlink
>>
>> which can be used for Rock and COSS.
>>
>
> done
>
>>
>>> if (!configured_once) {
>>> #if USE_UNLINKD
>>> - unlinkdInit();
>>> + if (unlinkdNeeded())
>>> + unlinkdInit();
>>> #endif
>>
>> Can the DiskIO strategy change during reconfigure? We may not support
>> that today, but it feels wrong to exclude such possibility. If you

Yes it can. When people switch between ufs/aufs/diskd.

Lets try to avoid loosing that ability.

Amos

-- 
Please be using
   Current Stable Squid 2.7.STABLE9 or 3.1.15
   Beta testers wanted for 3.2.0.12