Re: [PATCH] [RFC] pconn directive cleanup

On 8/11/2011 10:04 a.m., Alex Rousskov wrote:
> On 11/06/2011 11:12 PM, Amos Jeffries wrote:
>
>> + This is only relevant when persistent client connections
>> + are enabled. Non-persistent connections will close
>> + immediately after each request is completed.
> I would remove the above addition as obvious and slightly awkward OR
> rephrase it to just say something like "This option does not affect
> non-persistent client connections which are closed immediately after
> last use".
>
> The patch looks good to me.
>
> It would be useful to document whether setting the timeout to zero is
> meaningful as a way to optimize one-after-another requests without
> creating a lot of idle persistent connections.
>
>
> Thank you,
>
> Alex.

Done. And committed.

Amos
Received on Tue Nov 08 2011 - 09:24:26 MST