Re: /bzr/squid3/trunk/ r11978: Do not add HTTP 110 and 111 Warnings to TCP_REFRESH_UNMODIFIED responses.

On 01/20/2012 04:28 PM, Alex Rousskov wrote:
> ------------------------------------------------------------
> revno: 11978
> committer: Alex Rousskov <rousskov_at_measurement-factory.com>
> branch nick: trunk
> timestamp: Fri 2012-01-20 16:28:14 -0700
> message:
> Do not add HTTP 110 and 111 Warnings to TCP_REFRESH_UNMODIFIED responses.
>
> The old "stale if hit" logic did not account for cases where the stored stale
> response became fresh due to a successful revalidation with the origin server.
> When the stored response was stale at the time of the request, we were adding
> 110 "Response is stale" and even 111 "Revalidation failed" Warning headers to
> responses while logging TCP_REFRESH_UNMODIFIED, which is considered a hit.
> modified:
> src/client_side_reply.cc

Hi Amos,

    This one-line fix is needed in v3.2 and v3.1. I did not find any bug
reports referencing this.

Thank you,

Alex.
Received on Fri Jan 20 2012 - 23:24:51 MST