Re: [RFC] Time to talk about StringNG merge again?

On 29/03/2013 11:46 p.m., Kinkie wrote:
> Hi all,
> it's been a while since the last StringNG merge checkpoint , and
> several improvements were made in the meantime.
>
> I have briefly reviewed the previous requests for changes, I don't
> think there's any outstanding change requests; the new unit testing
> gives encouraging results (thanks Alex & Amos!).
>
> Feature branch is at lp:~squid/squid/stringng
>
> Questions were raised about the merge strategy - should we include the
> Tokenizer and additional stuff?
> My opinion: in order to minimize the effort, I'd like to merge
> everything, but marking everything but SBuf as
> experimental-do-not-touch or #ifdef-d out. It'd mean either a bit of
> unused shipped code or unused shipped files.
>
> Comments?

If the other stuff has not been reviewed, or is not able to pass review
quickly then NO please.

I am happy to spend some time assisting the cherry-picking process for
SBuf alone to go in as soon as it passes the audit if time and effort is
the worry.

Amos
Received on Fri Mar 29 2013 - 13:06:47 MDT