Re: [PATCH 3/8] reconfiguration leaks: TcpAcceptor job

On 25/04/2014 7:51 p.m., Amos Jeffries wrote:
> On 25/04/2014 12:48 p.m., Alex Rousskov wrote:
>> Do not leak TcpAcceptor job on reconfiguration
>> by monitoring and reacting to the listening socket closure.
>>
>> Every job that waits for Comm I/O must have a FD closure handler.
>> Unfortunately, we currently cannot enforce that rule automatically.
>>
>> Alex.
>>
>
> The unused parameter 'io' on Comm::TcpAcceptor::handleClosure() should
> be left without a name yes?
>
> +1. Please apply ASAP. The above can be fixed on commit.
>
> Amos
>

Applied as trunk rev.13432

Amos
Received on Mon Jun 02 2014 - 05:13:56 MDT