Re: [PATCH 4/8] reconfiguration leaks: Cache Manager menu items

On 25/04/2014 7:55 p.m., Amos Jeffries wrote:
> On 25/04/2014 12:50 p.m., Alex Rousskov wrote:
>> Do not register the same Cache Manager action more than once, to avoid
>> wrong mgr:menu output and the impression of a reconfigure memory leak.
>>
>> The old code was comparing action object pointers, which could not work,
>> and was adding the same action on every reconfigure call for modules
>> that register with Cache Manager during [re]configuration.
>>
>> We already have a working method for finding registered actions. Use it.
>>
>> Alex.
>>
>
> Ouch. I thought we had this is trunk a while back...
>
> +1 if it still needs to go in.
>
> Amos
>

Applied as trunk rev.13433

Amos
Received on Mon Jun 02 2014 - 05:19:39 MDT