Re: [PATCH] pconn_lifetime

From: Amos Jeffries <squid3_at_treenet.co.nz>
Date: Tue, 02 Sep 2014 12:51:27 +1200

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/09/2014 4:49 a.m., Tsantilas Christos wrote:
> Hi all,
>
> This patch add a new configuration option the 'pconn_lifetime' to
> allow users set the desired maximum lifetime of a persistent
> connection.
>
> When set, Squid will close a now-idle persistent connection that
> exceeded configured lifetime instead of moving the connection into
> the idle connection pool (or equivalent). No effect on
> ongoing/active transactions. Connection lifetime is the time period
> from the connection acceptance or opening time until "now".
>
> This limit is useful in environments with long-lived connections
> where Squid configuration or environmental factors change during a
> single connection lifetime. If unrestricted, some connections may
> last for hours and even days, ignoring those changes that should
> have affected their behavior or their existence.
>
> This is a Measurement Factory project

Two problems with this.

* the directive name does not indicate whether it applies to client,
server, or ICAP conections.

* the rationale for its need is a bit screwey.
 Any directives which affect Squid current running state need to
ensure in their post-reconfigure logics that state is consistent.
Preferrably create a runner, or use configDoConfigure if that is to much.

To support that we need some API updates to globally access the
currently active connection lists for servers/client/icap. But there
are other things like stats and reporting also needing that API, so we
should look at adding it instead of yet another "temporary" workaround.

Amos

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)

iQEcBAEBAgAGBQJUBRSPAAoJELJo5wb/XPRj+wQH/A/XVulpmlHL0aIFJBGJyL6m
GrB15odh+bK2U3K2++ZK+B3VDhNs6X44sG/XdA+bxGSw5E01oeIXQEZPoxzlAzO9
YBJx8zpBtnSlUAwuTwptomZPmbfsWDfOjtQQ0KLlccBpHJnb89M1w9O6bV3XT0hz
CRMPW1tY50R6U/HEBJWeXwwdeRfXJmeFru7sHE/evZCre17eVQ79zrcnlVjMciTD
Ag1ctW7C5u87b8iec81aW4X3dMG2IoQSER97dZ2Cde+tVqArK0UlfC9qZIi99DrT
7/WmdZpzPZyTJrCtZw8LD0iIMur7ez1o7kvSs4Z5AP0EPKAvHaTWwK9oASl2QDE=
=WtX2
-----END PGP SIGNATURE-----
Received on Tue Sep 02 2014 - 00:51:53 MDT

This archive was generated by hypermail 2.2.0 : Tue Sep 02 2014 - 12:00:11 MDT