Re: [PATCH] %<tt (total server time) is not computed in some cases

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 27/08/2014 11:08 p.m., Tsantilas Christos wrote:
> Hi all,
>
> The total server time is not computed in some cases, for example
> for CONNECT requests. An other example case is when server-first
> bumping mode is used and squid connects to SSL peer, but connection
> terminated before the SSL handshake completes.
>
> The attached patch is trying to fix these cases.
>
> This is a Measurement Factory project

+1, looks good. Some (optional) polishing though if you please.

* Since you are moving and touching most of the logics for
first_conn_start and total_response_time. Please take the opportunity
to upgrade their naming to camelCase and _ suffix.

Amos
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)

iQEcBAEBAgAGBQJUBRqiAAoJELJo5wb/XPRjQtsIAJxD4SPKoH5MoV3Nmk8P+d6V
rw7VSZ2uYK8ELT3llp6cYGBNafwyLaSop2UuX4q8O6D9GcwDnTgJSLfUiCuac0S5
q9T3HdJeRX069/B0SBJfLiuyTucO6MuWi8pKtoNuH6jDk8LG5CnCyj1PP2+PlZwn
hKv4tIcT61VBS7koCXt0+xI17g89X67jlc5gn2FSA8tTRwhpFKZDe7bmoMx/slwR
7TXZaUmnC+gSDkKZaTuX0ZgULOBuPtEE8+1Ku8/qpSX3TmUaaKa2JjKovuVAMugA
QIW8dzQGhpUOjb4YlPI+MVCgxIbgxtuB4GLxzYdf8KMmr+AksFs3wIWKIIGLKYg=
=9K5L
-----END PGP SIGNATURE-----
Received on Tue Sep 02 2014 - 01:17:39 MDT