Regex 'bug' found

From: Gerben Wierda <Gerben_Wierda@dont-contact.us>
Date: Wed, 5 Mar 97 23:26:01 +0100

Hello people,

Well, I found one 'bug'. My entries in the conf file looked like this:

acl activex urlpath_regex \.asp # regexp matching on any ActiveX prg
acl java urlpath_regex \.class # regexp matching on any Java prg

And when I crank debug to 9, the following is displayed:

97/03/05 23:10:29| aclMatchAclList: checking activex
97/03/05 23:10:29| aclMatchAcl: checking 'acl activex urlpath_regex \.asp
        # regexp matching on any ActiveX prg'
97/03/05 23:10:29| aclMatchRegex: checking '/Squid/documentation.html'
97/03/05 23:10:29| aclMatchRegex: looking for '\.asp'
97/03/05 23:10:29| aclMatchRegex: looking for '#'
97/03/05 23:10:29| aclMatchRegex: looking for 'regexp'
97/03/05 23:10:29| aclMatchRegex: looking for 'matching'
97/03/05 23:10:29| aclMatchRegex: looking for 'on'
97/03/05 23:10:29| aclMatchAclList: returning 1
97/03/05 23:10:29| aclCheck: match found, returning 0

So, what actually happens is that the part starting with '#' is not
considered a comment, which I had gathered from the comments in the default
config file which look like:

# acl aclname url_regex ^http:// ... # regex matching on whole URL
# acl aclname urlpath_regex \.gif$ ... # regex matching on URL path only

OTOH, that opens the question why the i486 version for NEXTSTEP doesn't
behave like this. Either one is wrong, so there is a bug somewhere. I can
check tomorrow, so if some kind soul can answer this soon, I can check
tomorrow morning when I have access to the other version again. Maybe the
other conf file did not have comments, that could also be, in which case it
is consistent with this one.

So my question is: how should squid behave? Should it ignore comments like
those displayed here (at the end of a line)? Or should it act as this trace
shows?

---
Gerben_Wierda@RnA.nl (Gerben Wierda) NEXTSTEP RD242
"If you don't know where you're going, any road will take you there"
Paraphrased in Alice in Wonderland, originally from the Talmud.
Renee: "Met veel koper maakt men hoempa." (After hearing a Nielsen symphony)
Received on Wed Mar 05 1997 - 14:59:25 MST

This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 16:34:37 MST