Re: using rfc931 ident with cache_peer_access

----- Original Message -----
From: "Duane Wessels" <wessels@squid-cache.org>
To: <squid-dev@squid-cache.org>
Sent: Wednesday, June 27, 2001 6:53 AM
Subject: using rfc931 ident with cache_peer_access

> Ref bugzilla #172.
>
> I recently committed a patch to HEAD and the 2.4 branch
> to make this work. After committing, I found it doesn't
> compile on HEAD because data structure members have been
> renamed and shuffled. In particular, the rfc931 string
> has been moved from request_t to ConnStateData.
>
> Currently there is no way to get at the rfc931 string from
> the peerAllowedToUse() function in src/neighbors.c. I guess
> that means we need to have a pointer in request_t to the
> parent ConnStateData. This already exists, and is called
> body_connection, but only seems to be set for requests with
> message bodies.
>
> Should we make the back pointer always available
> so we can access rfc931 in peerAllowedToUse? Or is
> there a better way?

I think making the back pointer available always isn't a bad thing. It
will make the available data more homogenous.

Rob
Received on Tue Jun 26 2001 - 17:01:19 MDT