Re: regarding squid bug# 879

I have found two possible places where code should be modified:

1) store_client.c(418): store_client::scheduleRead
if (copyInto.offset >= mem->inmem_lo &&
    copyInto.offset < mem->endOffset())
might be:
if (mem->hasContigousContentRange(copyInto.range()))

I guess here new problems might arise, right?

2) client_side_reply.cc(1612): clientGetMoreData()
if (context->flags.storelogiccomplete) {
  StoreIOBuffer tempBuffer;
  tempBuffer.offset = next->readBuffer.offset + context->headers_sz;
  tempBuffer.length = next->readBuffer.length;
  tempBuffer.data = next->readBuffer.data;
  storeClientCopy(context->sc, http->storeEntry(),
     tempBuffer, clientReplyContext::SendMoreData, context);
  return;
}

I guess tempBuffer member initialization should consider partial content replies, right?

Regards,

Gonzalo
Received on Tue Jan 20 2004 - 07:09:06 MST