quick_abort bug in squid 1.2 ?

From: Joao Carlos Mendes Luis <jonny@dont-contact.us>
Date: Fri, 12 Jun 1998 16:58:49 -0300 (EST)

Hi,

  I'm trying hard to find why my squid 1.2.b22 does quick abort all
my conection, even though I've told it to not abort:

quick_abort_min -1

  Peeking the sources I found that Config.quickAbort.min is of
type size_t, which in FreeBSD is defined at /usr/include/machine/ansi.h
as a unsigned int. At the file client_side.c, line 2344, function
CheckQuickAbort2(), we have:

...
    minlen = (int) Config.quickAbort.min;
    if (minlen < 0)
        /* disabled */
        return 0;
...

  Incredibly enough, gcc -Wall does not warn about signed comparisons
with unsigned vars. This always evaluated to false.

  I changed the var type at struct.h to ssize_t, And AFA I have tested
with gdb, the CheckQuickAbort() function now returns without calling
storeAbort(), but my squid is still quick aborting. Is there another
bug somewhere else, or is the quick abort feature now a default I cannot
disable ?

                                        Jonny

--
Joao Carlos Mendes Luis            M.Sc. Student
jonny@jonny.eng.br                 Universidade Federal do Rio de Janeiro
Received on Fri Jun 12 1998 - 13:00:27 MDT

This archive was generated by hypermail pre-2.1.9 : Tue Dec 09 2003 - 16:40:42 MST