Re: Duh! How do I apply memleak patch to 2.1P2?

Juan Carlos Castro y Castro wrote:
 
> Which directory has to be the current before I run

The top level source directory. squid-2.1.PATCH2
 
> And do I need a modifier like -p0 or -p1 or anything like that?

Always. You should never run patch without it.

Exactly which -pN option to use is a bit tricky as it depends on how the
patch was built. In this case you should use -p0, but my copy of
gnupatch 2.5 gets confused by this patch (can't automatically find
src/client_side.c no matter what option is used) unless the environment
variable POSIXLY_CORRECT is set. This seems to be a bug in this version
of patch as the man page seems to state otherwise and not accepting
patches like this is really annoying.

Hint to people making patches:
Make sure the patch is consistent in the header with local patch
including directory names in every part and not only in the Index: line.
If you are using cvs then never use cvs diff to prepare a patch, always
use cvs rdiff.

---
Henrik Nordstrom
Spare time Squid hacker